search

m-lab / mlab-ns

M-Lab name server (load balancer for M-Lab servers)
Apache License 2.0
12 stars 10 forks source link

Changes to begin preparing for project-decorated/flat names. #228

Closed nkinkade closed 4 years ago

nkinkade commented 4 years ago

This PR touches two particular files/functions that are incompatible with project-decorated/flat hostnames. These changes were enough to get the sandbox mlab-ns records for one sample site to include a project-decorated hostnames for its corresponding SliverTools.

NOTE: It was necessary to first manually remove the sample site from the GCD, then manually run the check_site cron job.

NOTE: There are likely other places in the mlab-ns code which will break with project-decorated/flat hostnames. It is hard to fully test this in sandbox, though.

This change is Reviewable

nkinkade commented 4 years ago

Travis-CI is currently down. Merging anyway, because the Cloud Build has already run all the unit tests (all passed) and deployed this version to sandbox. The only thing Travis-CI would bring us is coverage, which will happen eventually once Travis comes back up.