ndt7-js has a minimum nodejs version of 12 now, but this project was still at 10. Upgrading to v12 means that gulp had to be updated, too, since gulp 3.9.x and nodejs 12 aren't compatible. Upgrading gulp to v4.x.x meant I had to rewrite gulpfile.js to adapt it to the new syntax introduced in this version.
I got stuck for a while trying to figure out if I had broken gulp inject in the process. After looking at the version on master and the repository's history, it seems it never worked as intended as it references paths that have never existed. I will likely attempt to make it work in a subsequent PR, to not pollute this one with unrelated changes.
ndt7-js has a minimum nodejs version of 12 now, but this project was still at 10. Upgrading to v12 means that gulp had to be updated, too, since gulp 3.9.x and nodejs 12 aren't compatible. Upgrading gulp to v4.x.x meant I had to rewrite
gulpfile.js
to adapt it to the new syntax introduced in this version.I got stuck for a while trying to figure out if I had broken
gulp inject
in the process. After looking at the version onmaster
and the repository's history, it seems it never worked as intended as it references paths that have never existed. I will likely attempt to make it work in a subsequent PR, to not pollute this one with unrelated changes.