Add device_id and MURAKAMI_SETTINGS_DEVICE_ID

m-lab / murakami

Run automated internet measurement tests in a Docker container.

Apache License 2.0

41 stars 11 forks source link

Add device_id and MURAKAMI_SETTINGS_DEVICE_ID #63

Closed robertodauria closed 4 years ago

robertodauria commented 4 years ago

This PR adds the --device-id command line flag and the corresponding MURAKAMI_SETTINGS_DEVICE_ID environment variable.

This field is saved in each test runner's output as "MurakamiDeviceID": "value".

Please note that even if this is testable as-is, it will save the right value in the .jsonl only after https://github.com/m-lab/murakami/pull/62 has been merged, since reading the env variables is affected by that bug.

critzo commented 4 years ago

The recent commit doesn't result in MURAKAMI_DEVICE_ID being set.

critzo commented 4 years ago

LGTM @robertodauria I've confirmed the deviceID is now present in the file output and matches the Balena Cloud device id.