Fixing driver version check to work with Microsoft Edge

m-lab / ndt-e2e-clientworker

Code for the client worker of the NDT end-to-end test framework

Apache License 2.0

1 stars 4 forks source link

Fixing driver version check to work with Microsoft Edge #57

Closed mtlynch closed 8 years ago

mtlynch commented 8 years ago

Microsoft's WebDriver for edge places the browser version information in the 'browserVersion' field instead of the 'version' field. This adds a function that checks both fields if a 'version' field is not present and refactors both the banjo and HTML5 clients to use this function instead of reading the 'version' field directly.

This change is

coveralls commented 8 years ago

Coverage increased (+0.2%) to 88.33% when pulling 9837c7e7e86ba74d1b0c7e349d20c1e7f8817807 on mtlynch:browser-version into c8721f1f69e9af141817c927ebc9bfc53d4d3c72 on m-lab:master.

yachang commented 8 years ago

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

_tests/test_browser_client_common.py, line 96 [r1] (raw file):_ Add a test which has normal "version" field?

Comments from Reviewable

mtlynch commented 8 years ago

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

_tests/test_browser_client_common.py, line 96 [r1] (raw file):_ That is the intent of the test_get_version_returns_successfully_when_driver_has_standard_version test above. Did you have something else in mind?

Comments from Reviewable

yachang commented 8 years ago

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

_Comments from Reviewable_