Fixing a crash in banjo driver

m-lab / ndt-e2e-clientworker

Code for the client worker of the NDT end-to-end test framework

Apache License 2.0

1 stars 4 forks source link

Fixing a crash in banjo driver #62

Closed mtlynch closed 8 years ago

mtlynch commented 8 years ago

This fixes a crash in the banjo driver that occurred when load_url failed. The failure would cause perform_test to return None, but callers expect it to return a populated NdtResult object.

This fixes perform_test so that it always returns a populated NdtResult even if load_url fails.

This change is

coveralls commented 8 years ago

Coverage increased (+0.2%) to 88.489% when pulling e606dbb177462aefb6e49d96cc37567d3364acad on mtlynch:error-on-page-load into 3f03ccae949d5f83670a4764626ced2d1926479a on m-lab:master.

pboothe commented 8 years ago

Previously, coveralls wrote…

> [![Coverage Status](https://coveralls.io/builds/6119768/badge)](https://coveralls.io/builds/6119768) > > Coverage increased (+0.2%) to 88.489% when pulling **e606dbb177462aefb6e49d96cc37567d3364acad on mtlynch:error-on-page-load** into **3f03ccae949d5f83670a4764626ced2d1926479a on m-lab:master**. >

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.

_Comments from Reviewable_