search

m-lab / ndt-e2e-clientworker

Code for the client worker of the NDT end-to-end test framework
Apache License 2.0
1 stars 4 forks source link

Hang when page fails to load #69

Open mtlynch opened 8 years ago

mtlynch commented 8 years ago

I noticed a hang, so I checked the logs where the last entry was:

2016-05-27 11:43:37,793 banjo_driver INFO     loading URL: http://localhost:8888/banjo

It probably failed to connect to the server, in which case we should gracefully exit on timeout instead of waiting infinitely.

We probably want something like:

driver.set_page_load_timeout(10)

http://stackoverflow.com/a/17536547/3653712

fernandalavalle commented 8 years ago

Fixed for Firefox with: driver.set_page_load_timeout(10)

Page load timeout is ignored by the Chrome driver. Untested on Safari and Edge.

mtlynch commented 8 years ago

Updating to ChromeDriver 2.22 may fix this. From the release notes:

Changes include many bug fixes, particularly for Chrome 51+. This includes fixes for various scenarios that caused ChromeDriver to timeout and/or hang.

https://sites.google.com/a/chromium.org/chromedriver/downloads