m-lab / ndt-e2e-clientworker

Code for the client worker of the NDT end-to-end test framework
Apache License 2.0
1 stars 4 forks source link

Removing client_url parameter #84

Closed mtlynch closed 8 years ago

mtlynch commented 8 years ago

This parameter is actually unnecessary. It was originally added for the HTML5 client, which needs a URL rather than a server, but the URL of the HTML5 client can be deduced, given the server FQDN.

Eliminating the client_url parameter simplifies semantics and allows similar parameters to be used across different client types.


This change is Reviewable

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 87.462% when pulling 211755e68ede0b9d6a72eb17c3a02167c0676388 on mtlynch:remove-client-url into a3ee65140dd8d455fd812b392c2ebeca98e4a3e1 on m-lab:master.

fernandalavalle commented 8 years ago
:lgtm:

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable