m-lab / ndt-e2e-clientworker

Code for the client worker of the NDT end-to-end test framework
Apache License 2.0
1 stars 4 forks source link

Refactoring HTML5 driver #86

Closed mtlynch closed 8 years ago

mtlynch commented 8 years ago

Refactoring the HTML5 driver to use a private helper class so that the functions are not all passing around the same set of variables all the time. This brings the HTML5 driver closer in style to the banjo driver.

This is a non-functional change (pure refactoring) so does not require any changes to the unit tests.


This change is Reviewable

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.06%) to 87.519% when pulling 2bbbfdbd2295b16b2c5ffee9e5ce497a29eaae4f on mtlynch:refactor-html5-driver into 38bd5bcd0b8d5ffe0865c48ddf628f97083eda8b on m-lab:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.06%) to 87.519% when pulling 58392ac0e139871cf06e591c39bd6900b89dfe9c on mtlynch:refactor-html5-driver into 38bd5bcd0b8d5ffe0865c48ddf628f97083eda8b on m-lab:master.

nkinkade commented 8 years ago
:lgtm:

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


_Comments from Reviewable_