m-lab / ndt-server

docker native ndt5 and ndt7 server with prometheus integration
https://www.measurementlab.net/
Apache License 2.0
99 stars 40 forks source link

Remove bigquery ignore tag for ConnectionInfo #368

Closed cristinaleonr closed 2 years ago

cristinaleonr commented 2 years ago

This PR removes the bigquery:"-" tag from the ConnectionInfo field.

Because this optional field was to be ignored by BQ, it caused a fatal error in the Gardener in an instance where it was included in the json file and BQ did not recognize the field.

20220806:ndt/ndt7 Load {Location: "gs://etl-mlab-oti/ndt/ndt7/2022/08/06/20220806T040510.251033Z-ndt7-mlab2-gru02-ndt.tgz.json"; Message: "Error while reading data, error message: JSON parsing error in row starting at position 951624: No such field: raw.Download.ClientMeasurements.ConnectionInfo. File: gs://etl-mlab-oti/ndt/ndt7/2022/08/06/20220806T040510.251033Z-ndt7-mlab2-gru02-ndt.tgz.json"; Reason: "invalid"}

This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1583


Files with Coverage Reduction New Missed Lines %
ndt7/upload/sender/sender.go 5 65.91%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 1579: -0.2%
Covered Lines: 1767
Relevant Lines: 2168

💛 - Coveralls
stephen-soltesz commented 2 years ago

Related to: https://github.com/m-lab/dev-tracker/issues/731