m-lab / ndt-server

docker native ndt5 and ndt7 server with prometheus integration
https://www.measurementlab.net/
Apache License 2.0
101 stars 41 forks source link

Add error string label to bbr enabled metric #373

Closed stephen-soltesz closed 2 years ago

stephen-soltesz commented 2 years ago

We have learned that in practice, we see many status=false due to "bad file descriptor" errors. Unfortunately, this is not the error case we were originally interested in for the ndt7_measurer_bbr_enabled_total.

To be able to identify failures enabling BBR due to the module not being present, this change adds the error string to the metric labels. We are looking for the error "no such file or directory".


This change is Reviewable

stephen-soltesz commented 2 years ago

FYI: @nkinkade

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1609


Files with Coverage Reduction New Missed Lines %
ndt5/c2s/c2s.go 1 74.11%
ndt7/upload/sender/sender.go 5 65.91%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 1607: 0.07%
Covered Lines: 1803
Relevant Lines: 2208

💛 - Coveralls