Closed stephen-soltesz closed 2 years ago
FYI: @nkinkade
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
ndt5/c2s/c2s.go | 1 | 74.11% | ||
ndt7/upload/sender/sender.go | 5 | 65.91% | ||
<!-- | Total: | 6 | --> |
Totals | |
---|---|
Change from base Build 1607: | 0.07% |
Covered Lines: | 1803 |
Relevant Lines: | 2208 |
We have learned that in practice, we see many
status=false
due to "bad file descriptor" errors. Unfortunately, this is not the error case we were originally interested in for thendt7_measurer_bbr_enabled_total
.To be able to identify failures enabling BBR due to the module not being present, this change adds the error string to the metric labels. We are looking for the error
"no such file or directory"
.This change is