m-lab / ndt-server

docker native ndt5 and ndt7 server with prometheus integration
https://www.measurementlab.net/
Apache License 2.0
101 stars 41 forks source link

Update to golang 1.18 #375

Closed stephen-soltesz closed 2 years ago

stephen-soltesz commented 2 years ago

This change updates the Dockerfile.local to use go1.18.

This is part of https://github.com/m-lab/dev-tracker/issues/735


This change is Reviewable

SaiedKazemi commented 2 years ago

Dockerfile.local line 1 at r1 (raw file):

FROM golang:1.18-alpine3.14 as ndt-server-build

Can we use golang:1.18 (instead of golang:1.18-alpine3.14) so we don't have to install git, gcc, etc. on the next line?

This is actually what I did for dash, disco, uuid, and uuid-annorator.

Also, per official Go documentation: This variant is highly experimental, and not officially supported by the Go project (see golang/go#19938 for details). Details: https://hub.docker.com/_/golang

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1622


Files with Coverage Reduction New Missed Lines %
ndt5/ndt5.go 1 89.5%
ndt5/c2s/c2s.go 2 73.21%
ndt5/protocol/protocol.go 2 83.86%
ndt5/web100/web100_linux.go 2 94.44%
ndt7/upload/sender/sender.go 5 65.91%
<!-- Total: 12 -->
Totals Coverage Status
Change from base Build 1613: -0.5%
Covered Lines: 1795
Relevant Lines: 2208

💛 - Coveralls
SaiedKazemi commented 2 years ago

Dockerfile.local line 2 at r2 (raw file):

FROM golang:1.18 as ndt-server-build
RUN apk add --no-cache git gcc linux-headers musl-dev openssl bash

Since you are using golang:1.18, you shouldn't need this line (and apk doesn't exist).