search

m-lab / ndt

Network Diagnostic Tool
Other
11 stars 7 forks source link

Rewrote the queuing code to actually, y'know, work. #13

Closed pboothe closed 9 years ago

pboothe commented 9 years ago

Queuing now no longer uses semaphores, no longer has any (or not nearly as many) race conditions, and basically everything is better and more readable.

mtlynch commented 9 years ago

Finished this round of review

pboothe commented 9 years ago

Thanks! This made everything a lot clearer and cleaner. In the process, something broke (but only for the command-line client and not the websocket client!!?), so I'm debugging and will find the problem. Expect an updated pull request either late today or early tomorrow.

mtlynch commented 9 years ago

Note about the 4 magic number is unaddressed but otherwise LGTM