search

m-lab / ndt

Network Diagnostic Tool
Other
11 stars 7 forks source link

Fixed: server freeze and other SSL, error handling, and buffer bugs #22

Closed pboothe closed 8 years ago

pboothe commented 8 years ago

The bug where the server would freeze sometimes. (accept() was getting interrupted) The bug where SSL sockets would cause the META test to fail. The bug where the OS name got cut off at 32 chars, almost certainly clobbering a pointer which was stored later in the same struct. readn_any's error handling, because SSL_read can return an error which literally means "please call SSL_read". run_meta_test_srv's error handling now correctly logs the error

This change is Reviewable

stephen-soltesz commented 8 years ago

LGTM.

Added two comments, and updated the PR subject.