m-lab / ndt

Network Diagnostic Tool
Other
11 stars 7 forks source link

Audit of fixed-length strings in NDT #25

Open pboothe opened 8 years ago

pboothe commented 8 years ago

NDT has too many fixed-length strings, and this has been biting us for a long time. snprintf() doesn't actually promise that the resulting string ends up null-terminated, which leaves the door open for all sorts of crashing bugs. We should audit the usage of all strings in the meta global struct and writeMeta() in web100srv.c