Closed pboothe closed 8 years ago
write_raw & write_ssl - returns
0 success
writen_any - returns
0 success.
send_msg_any - uses return value from writen_any
Consistent return values / semantics by these functions would improve understandability.
There are some checks for impossible return values.
Standardized things on write()
's semantics instead of on SSL_write()
's semantics. Updated write_raw
and write_ssl
.
"git push"? There are no new commits atm.
Yes, I got occupied by getting the unit tests to pass, which has required work because we changed mlab_builder's network connection. I'll send a PTAL when it is good to go.
PTAL
Completed second round of comments.
PTAL
Third round of comments complete.
PTAL
Thank you. LGTM.
raw_write is unsafe in the presence of websockets, and it relies too heavily on write() and SSL_write having the same error semantics. Use writen_any instead.