Cleaned up logging, fixed a memory bug, improved the ndt_client.js

m-lab / ndt

Network Diagnostic Tool

Other

11 stars 7 forks source link

Cleaned up logging, fixed a memory bug, improved the ndt_client.js #35

Closed pboothe closed 8 years ago

pboothe commented 8 years ago

This change is

stephen-soltesz commented 8 years ago

LGTM.

Just some clarifying questions due to JS. I think the rate INFO messages for c2s & s2c could benefit from a unit like "Mbps", or similar.

stephen-soltesz commented 8 years ago

Please adopt a consistent approach to length / sizeof the static arrays in sigsafe_debug_log.

And, LGTM.

stephen-soltesz commented 8 years ago

One more comment: there are duplicate flags added to the web100srv for tls unit testing. This is a cleanup, since it doesn't appear to stop the server from starting.