search

m-lab / ndt

Network Diagnostic Tool
Other
11 stars 7 forks source link

Change 3 of N of adding SSL support to NDT. #5

Closed pboothe closed 9 years ago

pboothe commented 9 years ago

All the changes to the tests.

mtlynch commented 9 years ago

Finished this round of review

pboothe commented 9 years ago

PTAL

mtlynch commented 9 years ago

Finished this round of review.

pboothe commented 9 years ago

PTAL

mtlynch commented 9 years ago

It seems like we're running into a confusing case. If I have a note on round n and I want to continue the conversation in round n + 1, it's hard to see I kept commenting unless you go back and open every old comment.

Proposal: If I want to continue the conversation in n+1, I just copy paste the discussion into a new comment in round n + 1 instead of continuing the thread in round n. Does that work for you?

pboothe commented 9 years ago

That sounds great.

On Fri, May 8, 2015 at 4:54 PM, mtlynch notifications@github.com wrote:

It seems like we're running into a confusing case. If I have a note on round n and I want to continue the conversation in round n + 1, it's hard to see I kept commenting unless you go back and open every old comment.

Proposal: If I want to continue the conversation in n+1, I just copy paste the discussion into a new comment in round n + 1 instead of continuing the thread in round n. Does that work for you?

— Reply to this email directly or view it on GitHub https://github.com/m-lab/ndt/pull/5#issuecomment-100361364.

Peter Boothe | ɯoɔ˙ǝlƃooƃ@ǝɥʇooqd pboothe@google.com | ᴹ̶LAB | http://measurementlab.net

mtlynch commented 9 years ago

Remaining notes are just the ones that got lost between rounds. Copied them forward

pboothe commented 9 years ago

PTAL

mtlynch commented 9 years ago

LGTM