search

m-lab / ndt

Network Diagnostic Tool
Other
11 stars 7 forks source link

Remove controversial client bug workarounds. #68

Closed pboothe closed 8 years ago

pboothe commented 8 years ago

Removed all controversial client bug workarounds, leaving only SSL_OP_ALL.

The man page says:

It is usually safe to use SSL_OP_ALL to enable the bug workaround options if compatibility with somewhat broken implementations is desired.

This change is Reviewable

stephen-soltesz commented 8 years ago

Thank you. The change to src/web100srv.c LGTM.

I don't think old commits and previously reviewed diffs should appear in the history for new PR's. That's a little confusing.

Preferably new PRs would be based on the current HEAD of the target branch, or a rebase onto the local development branch from the target branch, or a single merge from the target branch to the local development branch.