m-lab / ndt

Network Diagnostic Tool
Other
11 stars 7 forks source link

Removes Java option from HTML interface served by NDT sliver (#73) #96

Closed stephen-soltesz closed 6 years ago

stephen-soltesz commented 6 years ago

This change is Reviewable

stephen-soltesz commented 6 years ago

@nkinkade added as original author.

@pboothe added as maintainer of upstream relationship. Speaking of which when was the last time we sync'd with upstream?

stephen-soltesz commented 6 years ago

Builds are failing due to dependency on an old version of builder image without Go. I'll fix it in the morning.

nkinkade commented 6 years ago
:lgtm:

I didn't go over every last detail of this PR with a fine-toothed comb because whenever I created this branch we are merging from, I had tested all the changes in the testbed and they worked as intended. The changes all look in line with what I remember doing all that time ago. :) In the odd event that something is broken, testbed e2e testing will catch it.


Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

stephen-soltesz commented 6 years ago

Builds are failing due to dependency on ndt-support dev branch.

Builds do not test the current version of ndt sources. :-/

I'm sorting this out.

stephen-soltesz commented 6 years ago

Travis build is still failing even though the m-lab/ndt is fixed in master. Not sure how to trick it into syncing again. Closing this PR and re-opening.

stephen-soltesz commented 6 years ago

HAHA, success!

stephen-soltesz commented 6 years ago

@pboothe I don't think you'll object, so I'm proceeding TBR.