search

m-lab / ooni-support

Support scripts for OONI on M-Lab
Apache License 2.0
10 stars 7 forks source link

Make openssl an explicit dependency of the Ooni RPM #40

Open defuse opened 10 years ago

defuse commented 10 years ago

If you forget to install yum-cron, you get:

[mlab_ooni@mlab1 tmp]$ sudo rpm -Uvh mlab_ooni.rpm 
error: Failed dependencies:
    yum-cron is needed by mlab_ooni-1.0.0-rc8.i686

If you forget to install openssl, you get:

$ sudo rpm -Uvh mlab_ooni.rpm 
error: Failed dependencies:
    libcrypto.so.10(OPENSSL_1.0.1) is needed by mlab_ooni-1.0.0-rc8.i686
    libcrypto.so.10(OPENSSL_1.0.1_EC) is needed by mlab_ooni-1.0.0-rc8.i686
    libcrypto.so.10(libcrypto.so.10) is needed by mlab_ooni-1.0.0-rc8.i686
    libssl.so.10(libssl.so.10) is needed by mlab_ooni-1.0.0-rc8.i686

The second should look more like the first, i.e. "openssl is needed by...".

defuse commented 10 years ago

This has been documented in the new README.

The yum-cron dependency is set in package/generic-slice.m4.spec:

Requires: cronie
Requires: crontabs
Requires: yum-cron

That file is not specific to Ooni, so I don't think we can properly add the openssl dependency to the RPM without adding it to all other M-Lab experiments.

defuse commented 10 years ago

So, to resolve this ticket, there needs to be some mechanism for experiments to provide a dependency list for the RPM. This is not necessary for an Ooni deployment, so I suggest we (Least Authority) not work on this, and instead defer it to M-Lab if they need it.

hawkinswnaf commented 10 years ago

I will talk to @technosopher about this. Having a "prereq" list seems like a good idea.