Remove paris traceroute and add latency metric

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes

Apache License 2.0

18 stars 5 forks source link

Remove paris traceroute and add latency metric #103

Closed gfr10598 closed 3 years ago

gfr10598 commented 3 years ago

We should also change the deployment in k8s-support to

use the scamper process instead of daemon
change trace timeout to 30m
change cache timeout to 30m

Also, see Issue #102

Testing: will test with manual deployment to sandbox

This change is

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 221

23 of 23 (100.0%) changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 99.641%

Files with Coverage Reduction	New Missed Lines	%
tracer/scamper.go	2	98.69%
<!--	Total:	2		-->

Totals
Change from base Build 186:	-0.4%
Covered Lines:	555
Relevant Lines:	557

💛 - Coveralls

SaiedKazemi commented 3 years ago

tracer/tracer.go, line 25 at r1 (raw file):

Quoted 4 lines of code…

> ``` > 1, 1.47, 2.15, 3.16, 4.64, 6.81, > 10, 14.7, 21.5, 31.6, 46.4, 68.1, > 100, 147, 215, 316, 464, 681, > 1000, 1470, 2150, 3160, 4640, 6810, > ```

Can we add a comment about these sequences? Maybe it's obvious to everyone, but not to me.