BUG: If scamper tracelb fails, we don't detect the failure.

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes

Apache License 2.0

18 stars 5 forks source link

BUG: If scamper tracelb fails, we don't detect the failure. #108

Closed gfr10598 closed 3 years ago

gfr10598 commented 3 years ago

When tracelb is run with bad parameters we see "do_scamperread_line: command not accepted" in the logs. But we apparently don't check any status.

laiyi-ohlsen commented 3 years ago

@gfr10598 Is this still relevant? @SaiedKazemi

SaiedKazemi commented 3 years ago

@laiyi-ohlsen I am assigning this bug to myself to check if it's already correctly handled or not. If so, will close the bug. If not, will add code to report/handle the error.

SaiedKazemi commented 3 years ago

Closing this bug because runTrace() in tracer/scamper.go checks for errors and logs them, distinguishing between timeouts and other types of errors.