Fix the format of scamper command argument

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes

Apache License 2.0

18 stars 5 forks source link

Fix the format of scamper command argument #111

Closed SaiedKazemi closed 3 years ago

SaiedKazemi commented 3 years ago

The flags that are passed to scamper's command (e.g., tracelb) via the -I flag should be specified as one string argument. Quotes are only needed when using the shell or printing log messages.

Tests:

go test ./...
docker-compose uy (tracetool=scamper) docker exec -it trc_traceroute-caller_1 apt-get update ... scamper.go:134: Trace succeeded in context 0xc0000bd620 ...

This change is

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 270

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.82%

Totals
Change from base Build 259:	0.0%
Covered Lines:	586
Relevant Lines:	593

💛 - Coveralls

SaiedKazemi commented 3 years ago

tracer/scamper.go, line 111 at r1 (raw file):

Previously, gfr10598 (Gregory Russell) wrote…

Please create this joined string in a local var above, and reuse it here and below.

Done.