Change string to []byte, and add some log init and skips to tests. - Githubissues

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes

Apache License 2.0

18 stars 5 forks source link

Change string to []byte, and add some log init and skips to tests. #115

Closed gfr10598 closed 3 years ago

gfr10598 commented 3 years ago

Almost a pure refactoring. Passing unit tests is sufficient.

This change is

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 298

24 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 98.827%

Totals
Change from base Build 287:	0.3%
Covered Lines:	590
Relevant Lines:	597

💛 - Coveralls