search

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes
Apache License 2.0
18 stars 5 forks source link

Add mod file to testdata directory #121

Closed cristinaleonr closed 3 years ago

cristinaleonr commented 3 years ago

When trying to import github.com/m-lab/traceroute-caller/parser, the following error gets thrown: cristinaleon@cristinaleon:~/go/src/github.com/m-lab/etl$ go get -v github.com/m-lab/traceroute-caller/parser go: downloading github.com/m-lab/traceroute-caller v0.9.0 go get github.com/m-lab/traceroute-caller/parser: create zip: parser/testdata/20130524T00:04:44Z_ALL5729.paris: malformed file path "parser/testdata/20130524T00:04:44Z_ALL5729.paris": invalid char ':'

This is because some of the names of the files under testdata include colons. I found this solution to put a go.mod file in the directory so that it's treated as a separate module when importing parser.

This change is Reviewable

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 369

Totals Coverage Status
Change from base Build 366: 0.3%
Covered Lines: 614
Relevant Lines: 644
💛 - Coveralls
SaiedKazemi commented 3 years ago

parser/testdata/go.mod, line 0 at r1 (raw file): We don't actually need this go.mod file because we can remove all *.paris files from the testdata directory because we no longer use or support paris-traceroute.

I will send you a PR to remove those files.

SaiedKazemi commented 3 years ago

We should get rid of the *.paris test files.