Explicitly ensure trace start times are in UTC

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes

Apache License 2.0

18 stars 5 forks source link

Explicitly ensure trace start times are in UTC #126

Closed SaiedKazemi closed 2 years ago

SaiedKazemi commented 2 years ago

Although Docker containers run in the UTC timezone by default, this PR uses time.UTC() to explicitly ensure that the trace start times parsed from scamper outout are in UTC. The trace start time is included in hopannotation1 file names and IDs.

This change was tested locally using docker-compose.

This change is

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 386

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.623%

Totals
Change from base Build 382:	0.0%
Covered Lines:	534
Relevant Lines:	547

💛 - Coveralls

SaiedKazemi commented 2 years ago

testdata/GeoLite2-City-incomplete.tar.gz, line at r1 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…

Reviewable doesn't show the specific diff for the binaries. Do we need to make changes to them?

Will revert to the original files.