m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes
Apache License 2.0
18 stars 5 forks source link

Remove explicit GOARCH in Dockerfile #131

Closed robertodauria closed 2 years ago

robertodauria commented 2 years ago

This PR removes an explicit GOARCH=amd64 in traceroute-caller's Dockerfile. I verified that this image can build just fine on an armv7 device, as long as GOARCH is autodetected.


This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 448


Totals Coverage Status
Change from base Build 446: 0.0%
Covered Lines: 624
Relevant Lines: 642

💛 - Coveralls
stephen-soltesz commented 2 years ago

@robertodauria ping -- this is still good right?