Closed SaiedKazemi closed 2 years ago
Totals | |
---|---|
Change from base Build 424: | 0.4% |
Covered Lines: | 559 |
Relevant Lines: | 579 |
@cristinaleonr Just FYI...
Thank you for your quick review.
tracer/scamper.go, line 40 at r1 (raw file):
Nice changes :+1:
Thank you. The original code didn't have a factory function and instantiated a Scamper
structure directly, putting values there. The current implementation is much better.
This commit adds a new function, NewScamper(), to the tracer package for creating a new instance of scamper based on the configuration specified in the call if the configuration is valid. The new scamper instance contains all of the information required for invoking the scamper binary to run a traceroute.
The changes were tested locally with go test and docker-compose.
This change is![Reviewable](https://reviewable.io/review_button.svg)