m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes
Apache License 2.0
18 stars 5 forks source link

Simplify code that executes scamper #138

Closed SaiedKazemi closed 2 years ago

SaiedKazemi commented 2 years ago

This commit uses the os/exec package to execute an instance of the scamper command. Previously, the m-lab/go/shx package was used because executing the scamper command was more elaborate and required a 3-stage pipeline.

Changes were tested locally with "go test" and also with "docker-compose"


This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 440


Totals Coverage Status
Change from base Build 438: 0.01%
Covered Lines: 617
Relevant Lines: 637

💛 - Coveralls
SaiedKazemi commented 2 years ago

tracer/scamper.go, line 178 at r1 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…
Do we want to add some context to this line we're printing out (like above)?

I don't think so because this is the standard error of the command (as opposed to a function's error message) which doesn't require additional context and is printed verbatim. The lines above it already provide context and details.

SaiedKazemi commented 2 years ago

Thanks for your review. Please see my explanation.

SaiedKazemi commented 2 years ago

Thanks.