Closed SaiedKazemi closed 2 years ago
Totals | |
---|---|
Change from base Build 438: | 0.01% |
Covered Lines: | 617 |
Relevant Lines: | 637 |
tracer/scamper.go, line 178 at r1 (raw file):
Do we want to add some context to this line we're printing out (like above)?
I don't think so because this is the standard error of the command (as opposed to a function's error message) which doesn't require additional context and is printed verbatim. The lines above it already provide context and details.
Thanks for your review. Please see my explanation.
Thanks.
This commit uses the os/exec package to execute an instance of the scamper command. Previously, the m-lab/go/shx package was used because executing the scamper command was more elaborate and required a 3-stage pipeline.
Changes were tested locally with "go test" and also with "docker-compose"
This change is![Reviewable](https://reviewable.io/review_button.svg)