Run two TRC containers locally for MDA and regular traceroutes

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes

Apache License 2.0

18 stars 5 forks source link

Run two TRC containers locally for MDA and regular traceroutes #139

Closed SaiedKazemi closed 2 years ago

SaiedKazemi commented 2 years ago

This commit contains changes for running two instances of the traceroute-caller container locally via docker-compose. One instance runs MDA traceroutes (scamper1 datatype) and the other instance runs regular traceroutes (scamper2 datatype).

Changes tested locally with "go test -race" and also with "docker-compose".

This change is

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 445

12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 97.196%

Totals
Change from base Build 441:	0.3%
Covered Lines:	624
Relevant Lines:	642

💛 - Coveralls

SaiedKazemi commented 2 years ago

hopannotation/hopannotation.go, line 111 at r1 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…

Just want to double check that the invalid config error is the right one to return when `ctx == nil`.

I changed the error message to "invalid context or hop annotation configuration".

SaiedKazemi commented 2 years ago

Thank you @cristinaleonr . I made the error message more accurate. PTAL.