Closed maxmouchet closed 2 years ago
@maxmouchet Thank you for the PR. I will review and comment soon.
@maxmouchet I did a quick hack to run fast-mda-traceroute
instead of scamper
and the result is very promising :)
scamper.go:171: context 0xc0000b2000: command started: /usr/local/bin/fast-mda-traceroute --format scamper-json 91.189.91.38
scamper.go:171: context 0xc0000b2cc0: command started: /usr/local/bin/fast-mda-traceroute --format scamper-json 185.125.190.36
scamper.go:175: context 0xc0000b2000: command finished in 3.107314684 seconds
scamper.go:191: context 0xc0000b2000: command succeeded
scamper.go:175: context 0xc0000b2cc0: command finished in 3.111992665 seconds
scamper.go:191: context 0xc0000b2cc0: command succeeded
I need to discuss including python3-pip and pre-built binaries in the traceroute-caller image with @stephen-soltesz and decide the next steps.
@SaiedKazemi super ! :-)
Regarding caracal's Python extension, it's possible to build it in a separate stage but this can take some time (caracal/runs/5481874842
suggests around 5 minutes without caching).
See caracal/Dockerfile
to get an idea of the build dependencies (for the main binary, but they are similar for the Python extension).
Sorry for the delay (due to other priorities) in any updates for this PR.
We will discuss the next steps when we meet in person next week.
@SaiedKazemi I updated the Dockerfile to build caracal's Python extension from source, instead of pulling the precompiled binary from PyPI. Image build time is around 3 minutes.
@maxmouchet Thank you for this PR. As we discussed offline, I will be out the next two weeks and will work on this as soon as I am back.
@maxmouchet I have prepared traceroute-caller source code for merging this PR. Can you please rebase this PR? Should rebase without any issues.
Done!
This adds fast-mda-traceroute to the Docker image so that it can be called by traceroute-caller. @SaiedKazemi please let me know if this works for you!
This relies on caracal's precompiled binaries hosted on PyPI, so it should work out-of-the-box on x86_64 and aarch64 systems.
This change is![Reviewable](https://reviewable.io/review_button.svg)