Make MDA traceroutes the default traceroute type

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes

Apache License 2.0

18 stars 5 forks source link

Make MDA traceroutes the default traceroute type #147

Closed SaiedKazemi closed 2 years ago

SaiedKazemi commented 2 years ago

This commit does not introduce any functional changes. Its main purpose is to make MDA traceroutes the default traceroute type and run only one traceroute-caller container when using docker-compose for local development and debugging. Also, this commit replaces the deprecated "ioutil" calls with their equivalents in the "os" package.

Changes were tested locally.

This change is

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 483

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.904%

Totals
Change from base Build 479:	0.0%
Covered Lines:	626
Relevant Lines:	646

💛 - Coveralls

SaiedKazemi commented 2 years ago

caller_test.go line 31 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

Same suggestion for https://pkg.go.dev/testing#T.TempDir here..

Unfortunately testing.M does not provide a TempDir() method.

SaiedKazemi commented 2 years ago

tracer/scamper_test.go line 69 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

Is it possible to use https://pkg.go.dev/testing#T.TempDir ? These auto-clean up after the tests end. Some tests below use `defer os.RemoveAll(tempdir)` but this one doesn't seem to. `t.TempDir()` should make it unnecessary.

Great suggestion!

SaiedKazemi commented 2 years ago

Thank you.