Closed SaiedKazemi closed 2 years ago
Totals | |
---|---|
Change from base Build 479: | 0.0% |
Covered Lines: | 626 |
Relevant Lines: | 646 |
caller_test.go
line 31 at r1 (raw file):
Same suggestion for https://pkg.go.dev/testing#T.TempDir here..
Unfortunately testing.M
does not provide a TempDir()
method.
tracer/scamper_test.go
line 69 at r1 (raw file):
Is it possible to use https://pkg.go.dev/testing#T.TempDir ? These auto-clean up after the tests end. Some tests below use `defer os.RemoveAll(tempdir)` but this one doesn't seem to. `t.TempDir()` should make it unnecessary.
Great suggestion!
Thank you.
This commit does not introduce any functional changes. Its main purpose is to make MDA traceroutes the default traceroute type and run only one traceroute-caller container when using docker-compose for local development and debugging. Also, this commit replaces the deprecated "ioutil" calls with their equivalents in the "os" package.
Changes were tested locally.
This change is![Reviewable](https://reviewable.io/review_button.svg)