Closed SaiedKazemi closed 2 years ago
Totals | |
---|---|
Change from base Build 486: | -0.04% |
Covered Lines: | 617 |
Relevant Lines: | 637 |
tracer/scamper_test.go
line 278 at r1 (raw file):
Code health improves and code coverage decreases. Is it possible to construct a new test case that preserves the error path coverage in scamper.go? https://coveralls.io/builds/50681303/source?filename=tracer%2Fscamper.go#L91
I adde an explicit test for empty UUIDs and get a coverage of 99%. PTAL.
Yes, of course. Coverage is now 99%. PTAL.
The Linux kernel provides a unique cookie for each TCP socket connection. The cookie value is used by the tcp-info package to generate a global UUID that is passed to tcp-info's eventsocket clients. Therefore, there is no reason for clients to know about cookies or generate UUIDs from them.
This commit removes the notion of TCP socket cookies from traceroute-caller.
Tested the changes locally with docker-compose.
This change is![Reviewable](https://reviewable.io/review_button.svg)