Remove the notion of TCP socket cookies

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes

Apache License 2.0

18 stars 5 forks source link

Remove the notion of TCP socket cookies #148

Closed SaiedKazemi closed 2 years ago

SaiedKazemi commented 2 years ago

The Linux kernel provides a unique cookie for each TCP socket connection. The cookie value is used by the tcp-info package to generate a global UUID that is passed to tcp-info's eventsocket clients. Therefore, there is no reason for clients to know about cookies or generate UUIDs from them.

This commit removes the notion of TCP socket cookies from traceroute-caller.

Tested the changes locally with docker-compose.

This change is

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 490

27 of 27 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 96.86%

Totals
Change from base Build 486:	-0.04%
Covered Lines:	617
Relevant Lines:	637

💛 - Coveralls

SaiedKazemi commented 2 years ago

tracer/scamper_test.go line 278 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

Code health improves and code coverage decreases. Is it possible to construct a new test case that preserves the error path coverage in scamper.go? https://coveralls.io/builds/50681303/source?filename=tracer%2Fscamper.go#L91

I adde an explicit test for empty UUIDs and get a coverage of 99%. PTAL.

SaiedKazemi commented 2 years ago

Yes, of course. Coverage is now 99%. PTAL.