m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes
Apache License 2.0
18 stars 5 forks source link

Add time columns to output and make some code improvements #149

Closed SaiedKazemi closed 2 years ago

SaiedKazemi commented 2 years ago

This commit adds probe transmit and reply receive times to the output it generates. This commit also makes some code improvements.

The changes were tested locally using .jsonl archives from GCS.


This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 495


Totals Coverage Status
Change from base Build 491: 0.0%
Covered Lines: 617
Relevant Lines: 637

💛 - Coveralls
SaiedKazemi commented 2 years ago

@stephen-soltesz Thank you for your review. I've made edits based on your and Maxime's feedback. PTAL.

SaiedKazemi commented 2 years ago

cmd/trex/main.go line 213 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…
Did you also consider `fmt.Fprintf` and `bytes.Buffer` for this case?

I left it as is for now unless you think it's important to change it.

SaiedKazemi commented 2 years ago

PTAL.