m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes
Apache License 2.0
18 stars 5 forks source link

Fix building issues with fast-mda-traceroute #160

Closed matthieugouel closed 1 year ago

matthieugouel commented 1 year ago

Hi,

@SaiedKazemi noticed me that the ci/dockercloud-stage was still failing (see #152) due to the building of fast-mda-traceroute (FMT), and in particular pycaracal dependency.

Luckily I could reproduce the issue locally this time. I think the issue could be resolved by simply updating Python packaging management tools (pip, wheel and setuptool) before installing pycaracal and FMT in the Dockerfile :

RUN pip3 install --upgrade pip wheel setuptools

Unfortunately, this simple change led to a cascade of other changes in pycaracal (https://github.com/dioptra-io/caracal/pull/53, https://github.com/dioptra-io/caracal/pull/54) and FMT(https://github.com/dioptra-io/fast-mda-traceroute/pull/3) to make it work properly (the principal reason is that now Conan is by default in version 2.0, which lead to breaking changes in pycaracal build) .

It works now locally but I also had to upgrade the Ubuntu Docker image from 20.04 to 22.04 to have Python 3.10 by default. If it's not ok for other reasons, we could also just update the Python version to 3.10 in the 20.04 Ubuntu Docker image.

If it looks good to you, we could test if the Docker CI works with these changes.

Best, Matthieu.


This change is Reviewable

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 562


Totals Coverage Status
Change from base Build 557: 0.0%
Covered Lines: 669
Relevant Lines: 697

💛 - Coveralls
SaiedKazemi commented 1 year ago

@matthieugouel Thank you for this PR. The Travis CI build was successful so I will merge it.

SaiedKazemi commented 1 year ago

@matthieugouel Docker Hub builds are also successful.