Add metric for cached traces - Githubissues

m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes

Apache License 2.0

18 stars 5 forks source link

Add metric for cached traces #80

Closed yachang closed 3 years ago

yachang commented 4 years ago

This change is

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 466

2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 97.359%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tracer/scamper.go	2	3	66.67%
<!--	Total:	2	3	66.67%	-->

Files with Coverage Reduction	New Missed Lines	%
caller.go	2	97.83%
<!--	Total:	2		-->

Totals
Change from base Build 455:	-0.3%
Covered Lines:	1069
Relevant Lines:	1098

💛 - Coveralls

yachang commented 4 years ago

Here is the updated dashboard using sandbox data:

https://grafana.mlab-sandbox.measurementlab.net/d/acgDDJ-Zz/yachang-traceroute-caller-launch-monitoring?orgId=1&var-datasource=Platform%20Cluster%20(mlab-sandbox)&var-deployment=ndt&var-datatype=traceroute&var-machine=mlab1&var-site=lga0t&from=now-15m&to=now