m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes
Apache License 2.0
18 stars 5 forks source link

Rename vendor to third_party #88

Closed SaiedKazemi closed 3 years ago

SaiedKazemi commented 3 years ago

This commit renames vendor to third_party because the usage of the vendor directory in this repo is not consistent with Go's conventions for the vendor directory (https://golang.org/src/README.vendor). Specifically, the vendor directory contains two third-party packages written in C, scamper and libparistraceroute, where the first one is included as a source tarball and the second one as a Git submodule.

The changes were successfully tested by running:

docker build -t traceroute-caller:latest .


This change is Reviewable

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 87


Totals Coverage Status
Change from base Build 70: 0.0%
Covered Lines: 1069
Relevant Lines: 1095

💛 - Coveralls
stephen-soltesz commented 3 years ago

Please double check the docker build error.