m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes
Apache License 2.0
18 stars 5 forks source link

Update Travis CI configuration in .travis.yml #90

Closed SaiedKazemi closed 3 years ago

SaiedKazemi commented 3 years ago

This commit makes two changes:

  1. It removes "docker build ." because Travis builds are failing due to Docker Hub rate limits and we don't need the continer image that Travis builds anyway.

  2. It moves uploading of coverage information to the "after_success" stage so that a failure in uploading coverage doesn't cause Travis to fail.

Tested via a push to my feature branch, triggering a build. Both Docker Hub and Travis CI passed.


This change is Reviewable

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 103


Totals Coverage Status
Change from base Build 94: 0.0%
Covered Lines: 1069
Relevant Lines: 1095

💛 - Coveralls
gfr10598 commented 3 years ago

Yes - dockerhub builds the docker container, and our k8s deployment k8s-support gets it from dockerhub (we think).