m-lab / traceroute-caller

A sidecar service which runs traceroute after a connection closes
Apache License 2.0
18 stars 5 forks source link

Add comments to json.go #94

Closed gfr10598 closed 3 years ago

gfr10598 commented 3 years ago

I haven't figured out how to suppress warnings from golint. Various urls suggest that //nolint or // nolint should work, but they do not.

We may actually be able to change the names to use camelCase, but for now let's leave them as is, and tolerate the warnings until we can figure out how to suppress them.

There are no code changes aside from renaming RTT and TTL, so go vet and travis tests are sufficient to ensure correctness.


This change is Reviewable

SaiedKazemi commented 3 years ago

Yeah, I was also looking into how we can tell golint to ignore certain errors but couldn't find anything that would work for me.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 121


Totals Coverage Status
Change from base Build 118: 0.0%
Covered Lines: 1069
Relevant Lines: 1099

💛 - Coveralls