m-lab / uuid-annotator

Produces metadata locally for every connection on each server.
Apache License 2.0
0 stars 0 forks source link

Define canonical Geo and Network structures in annotator package #17

Closed stephen-soltesz closed 4 years ago

stephen-soltesz commented 4 years ago

This change forks the annotation-service/api types to allow:

This change also temporarily disables the asn annotator support because the type changes require a different implementation of the route view parsing and search routines. That will be added in a subsequent PR to reenable ASN annotation.


This change is Reviewable

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 121


Changes Missing Coverage Covered Lines Changed/Added Lines %
asnannotator/routeview.go 0 3 0.0%
<!-- Total: 60 63 95.24% -->
Files with Coverage Reduction New Missed Lines %
asnannotator/routeview.go 84 0%
<!-- Total: 84 -->
Totals Coverage Status
Change from base Build 104: -20.7%
Covered Lines: 304
Relevant Lines: 391

💛 - Coveralls
stephen-soltesz commented 4 years ago

https://github.com/m-lab/dev-tracker/issues/534