Adds IP decoration and a main method

m-lab / uuid-annotator

Produces metadata locally for every connection on each server.

Apache License 2.0

0 stars 0 forks source link

Adds IP decoration and a main method #2

Closed pboothe closed 4 years ago

pboothe commented 4 years ago

Adds a main() and annotation from MaxMind zipfiles.

GCS functionality is still missing, but this PR is big enough without that.

This change is

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 36

101 of 101 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 18:	0.0%
Covered Lines:	149
Relevant Lines:	149

I honestly don't understand why coveralls still thinks coverage is at 100%. It's not. ipannotator and main are 100% covered. annotator contains no code, only structs and interfaces, and zipfile is untested and its most important method returns errors.New("unimplemented")

pboothe commented 4 years ago

https://github.com/m-lab/dev-tracker/issues/534

m-lab / uuid-annotator

Adds IP decoration and a main method #2

Pull Request Test Coverage Report for Build 36

💛 - Coveralls