Assign server annotations when IP is in server netblocks

m-lab / uuid-annotator

Produces metadata locally for every connection on each server.

Apache License 2.0

0 stars 0 forks source link

Assign server annotations when IP is in server netblocks #21

Closed stephen-soltesz closed 4 years ago

stephen-soltesz commented 4 years ago

This change updates the siteinfo struct used to import the server annotations so that it includes the ipv4 and ipv6 netblocks for the site. Assigning server annotations are now conditional on IPs being within that netblock. As a result, private IPs will not be annotated with the server annotations.

This change also adds additional test cases to testdata/annotations.json

This change is

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 151

32 of 32 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 142:	0.0%
Covered Lines:	566
Relevant Lines:	566

💛 - Coveralls

stephen-soltesz commented 4 years ago

https://github.com/m-lab/dev-tracker/issues/534