m-lab / uuid-annotator

Produces metadata locally for every connection on each server.
Apache License 2.0
0 stars 0 forks source link

Allow annotations when the local server IP is not contained in siteinfo public IP netblock #44

Closed stephen-soltesz closed 2 years ago

stephen-soltesz commented 2 years ago

This change updates the uuid-annotator logic to be more permissive for siteinfo annotations when the local IP is not contained in the siteinfo public IP netblock. This can occur when deployments to GCE VMs have a public IP registered with siteinfo but the uuid-annotator only knows about the local private server IP. With this change, rather than checking that the source IP is contained within the siteinfo netblock, we accept that the local IP is the server IP and annotate using the siteinfo annotations, using the appropriate ipv4 or ipv6 address. If there is no registered IPv4 or IPv6 netblock in siteinfo then no annotation is recorded.

Fixes #43


This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 259


Totals Coverage Status
Change from base Build 256: 0.0%
Covered Lines: 726
Relevant Lines: 726

💛 - Coveralls