m-lab / uuid-annotator

Produces metadata locally for every connection on each server.
Apache License 2.0
0 stars 0 forks source link

Upgrade repo to Go 1.18 #47

Closed SaiedKazemi closed 2 years ago

SaiedKazemi commented 2 years ago

This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 276


Totals Coverage Status
Change from base Build 271: 0.0%
Covered Lines: 718
Relevant Lines: 718

💛 - Coveralls
SaiedKazemi commented 2 years ago

Dockerfile line 5 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…
You mentioned wanting to use `CGO_ENABLED=0` here also. I think that too will be necessary for the different build & final environments.

Yes, based on our conversation and consistent with best practices, I will explicitly set CGO_ENABLED=0 here and in other repos I will upgrade to Go 1.18.

SaiedKazemi commented 2 years ago

Will send follow up.

SaiedKazemi commented 2 years ago

I just committed an updated go.sum file.