Use the whole provided hostname for siteinfo lookup

m-lab / uuid-annotator

Produces metadata locally for every connection on each server.

Apache License 2.0

0 stars 0 forks source link

Use the whole provided hostname for siteinfo lookup #67

Closed robertodauria closed 5 months ago

robertodauria commented 6 months ago

This replaces host.String() with host.StringWithService() so that v3 hostnames (<service>-<metro><asn>-<ipv4>...) can work.

In our daemonset templates uuid-annotator is passed MLAB_NODE_NAME which does not include the service name, so this change shouldn't affect uuid-annotator's typical usage while enabling BYOS hostnames.

This change is

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 354

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.117%

Totals
Change from base Build 351:	0.0%
Covered Lines:	786
Relevant Lines:	793

m-lab / uuid-annotator

Use the whole provided hostname for siteinfo lookup #67

Pull Request Test Coverage Report for Build 354

Details

💛 - Coveralls