m-labs / artiq

A leading-edge control system for quantum information experiments

https://m-labs.hk/artiq

GNU Lesser General Public License v3.0

426 stars 198 forks source link

applets: EntryArea return processed values #2378

Closed SimonRenblad closed 6 months ago

SimonRenblad commented 6 months ago

ARTIQ Pull Request

Description of Changes

Make gui.applets.EntryArea return processed values.
Return a SimpleNamespace object instead of a dictionary in get_values.

Reason: Consistency with the interactive arguments feature and experiments.

Steps

All Pull Requests

[x] Use correct spelling and grammar.
[x] Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).

Code Changes

[x] Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
[x] Test your changes or have someone test them. Mention what was tested and how. Tested with applet implementing 'EntryArea'

Git Logistics

[x] Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
[x] Write short & meaningful commit messages. Review each commit for messages (git show). Format:
```
topic: description. < 50 characters total.

Longer description. < 70 characters per line
```

Licensing

See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.