Expands examples/no_hardware/repository/interactive.py with all value types used in arguments_demo.py.
Related Issue
Closes #2373
Type of Change
Type
✓
:sparkles: New feature
Steps
All Pull Requests
[x] Use correct spelling and grammar.
[ ] Close/update issues.
[x] Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).
Code Changes
[x] Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
[x] Test your changes or have someone test them. Mention what was tested and how.
Testing
Test
Observation
artiq_client show interactive-args
Title is shown and shows all arguments properly.
supply-interactive` with valid arguments (tested with multiple scan types)
Prints all arguments as expected. Scan works as expected.
supply-interactive with incorrect number of args
Experiment is not deleted. ValueError: supplied and requested keys do not match
supply-interactive with correct number of args but invalid values (tested for each type)
Experiment is deleted. Various TypeError / ValueError depending on type tested.
Git Logistics
[x] Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
[x] Write short & meaningful commit messages. Review each commit for messages (git show). Format:
topic: description. < 50 characters total.
Longer description. < 70 characters per line
Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.
ARTIQ Pull Request
Description of Changes
Expands
examples/no_hardware/repository/interactive.pywith all value types used inarguments_demo.py.Related Issue
Closes #2373
Type of Change
Steps
All Pull Requests
git commit --signoff, see copyright).Code Changes
flake8to check code style (follow PEP-8 style).flake8has issues with parsing Migen/gateware code, ignore as necessary.Testing
artiq_client show interactive-argssupply-interactivewith incorrect number of argssupply-interactivewith correct number of args but invalid values (tested for each type)TypeError/ValueErrordepending on type tested.Git Logistics
git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.[x] Write short & meaningful commit messages. Review each commit for messages (
git show). Format:Licensing
See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.