Closed SimonRenblad closed 2 months ago
Updated alternative solution:
Here is how it compares to previous proposals.
Pros:
procdesc_entry
requiredCons:
set_quickstyle
method, which means widget display is no longer one-to-one with its argument. This is somewhat unavoidable due to the nature of altering widgets at a "dashboard/browser level" in a way that contradicts how they were set at an "experiment level". Since "quickstyle" does not alter the resulting value in experiments in any way, this may still be acceptable.Update:
Small change, still a mutation but now in initialize_submission_arguments
.
ARTIQ Pull Request
Description of Changes
Disables
quickstyle
widgets inartiq_browser
.quickstyle
widgets will display as if option was not enabled.Steps
All Pull Requests
git commit --signoff
, see copyright).Code Changes
flake8
to check code style (follow PEP-8 style).flake8
has issues with parsing Migen/gateware code, ignore as necessary.Documentation Changes
cd doc/manual/; make html
) to ensure no errors.Git Logistics
git rebase --interactive
). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.[x] Write short & meaningful commit messages. Review each commit for messages (
git show
). Format:Licensing
See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.