m-labs / artiq

A leading-edge control system for quantum information experiments
https://m-labs.hk/artiq
GNU Lesser General Public License v3.0
414 stars 192 forks source link

Enable spread in satellite, use high watermark for SED #2412

Closed Spaqin closed 1 month ago

Spaqin commented 1 month ago

ARTIQ Pull Request

Description of Changes

This PR changes the way the lane distributor switches lanes in SED. Instead of relying on the queue being full at first and then an event being taken out, a hardcoded high watermark is implemented instead. Additionally, event spreading is enabled for satellites. For standalone or master, the watermark is set at 100% (just full), for satellite it is 75%. Exact good values would have to be determined experimentally.

Flash config option is not supported yet - would require a CSR interface, that can be added at a later moment.

Tested with Kasli 2.0 with the experiment code mentioned in #1881 that would underflow, does not underflow now.

Related Issue

Closes #1881

Type of Changes

Type
:bug: Bug fix

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

Code Changes

Git Logistics

Licensing

See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

sbourdeauducq commented 1 month ago

Needs update of release notes.