search

m-labs / artiq

A leading-edge control system for quantum information experiments
https://m-labs.hk/artiq
GNU Lesser General Public License v3.0
426 stars 197 forks source link

Should Zadig be included in the offline installer? #2428

Closed sbourdeauducq closed 3 months ago

thomasfire commented 3 months ago

Despite that zadig can be built within MSYS2, and even if it didn't, we still could just include the binary, I doubt it would add better experience here:

  1. It requires admin privileges, which result in "Permission denied" when you try run it in MSYS2, unless you run whole MSYS2 as an admin. So instead of double click -> click in UAC -> install driver, users would need to do: run MSYS2 as admin -> click in UAC -> type something like zadig and Enter -> install drivers. Running whole MSYS2 as admin is not a good idea.
  2. If it needs to run during installation, then it would require the crate to be connected, which may be disturbing and irrelevant, since the installation may be done by admins, and not users

However, I guess it can be added as a root-level binary, similar to the terminal EXEs, and then have a link in Start menu. This way it should automatically prompt UAC if needed, in similar way as it done if you double click it from Explorer. So this way it would be "Start menu" -> ARTIQ folder or search -> click zadig -> click in UAC -> install drivers.

sbourdeauducq commented 3 months ago

unless you run whole MSYS2 as an admin

MSYS2 binaries are native Windows binaries and can be executed outside MSYS2.

sbourdeauducq commented 3 months ago

Needs update of ARTIQ-9 docs to mention inclusion with the MSYS2 offline installer.